Fix macro hygiene #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
approved these changes
Jul 13, 2023
|
It ran locally because I forgot to re-dev my test env. Still figuring out how to fix this.. |
|
Ugh, we're running into JuliaLang/julia#37691 |
|
what's the issue? |
|
Oh, |
|
Yeah, from https://discourse.julialang.org/t/optional-macro-invocation/18588/21?page=2: macro threaded(device, loop)
quote
if $(esc(device)) isa CPUMultiThreaded
Threads.@threads $(Expr(
loop.head,
Expr(loop.args[1].head, esc.(loop.args[1].args)...),
esc(loop.args[2]),
))
else
@assert $(esc(device)) isa AbstractDevice
$(esc(loop))
end
end
endseems to work. It's not quite as pretty though.. Thoughts @simonbyrne ? |
Fix macro hygiene Bump patch version
charleskawczynski
force-pushed
the
ck/tests
branch
from
5b1a91d
to
ea983ec
Compare
|
that might be the least-worst solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in https://buildkite.com/clima/climacoupler-ci/builds/1372#01895016-b183-41a3-93fc-fbef7e2cf455/142-211, this PR: